Add skeleton structure for tiering status API#21017
Conversation
|
Failed to generate code suggestions for PR |
|
❌ Gradle check result for f378ff6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f378ff6 to
52a6cf3
Compare
|
Failed to generate code suggestions for PR |
|
❌ Gradle check result for 52a6cf3: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
52a6cf3 to
c2f0570
Compare
|
Failed to generate code suggestions for PR |
|
❌ Gradle check result for c2f0570: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
c2f0570 to
96b9419
Compare
PR Reviewer Guide 🔍(Review updated until commit 6272274)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 6272274 Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit 3e7a513
Suggestions up to commit 00e93b5
Suggestions up to commit 6ef0bb2
Suggestions up to commit a346d4d
Suggestions up to commit a92526e
|
96b9419 to
130e125
Compare
|
Persistent review updated to latest commit 130e125 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21017 +/- ##
============================================
- Coverage 73.35% 73.28% -0.08%
+ Complexity 73209 73167 -42
============================================
Files 5921 5932 +11
Lines 333798 333924 +126
Branches 48124 48125 +1
============================================
- Hits 244862 244719 -143
- Misses 69387 69643 +256
- Partials 19549 19562 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chaitanya588
left a comment
There was a problem hiding this comment.
In few classes, i am seeing default constructors. Can you add the specific overloaded constructors here?
- TransportTierAction
- TransportGetTieringStatusAction
- TransportListTieringStatusAction
- TransportCancelTierAction
130e125 to
e96ceb8
Compare
|
Persistent review updated to latest commit e96ceb8 |
|
❌ Gradle check result for e96ceb8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e96ceb8 to
a30ef73
Compare
|
Persistent review updated to latest commit a30ef73 |
a30ef73 to
a81330c
Compare
|
Persistent review updated to latest commit a81330c |
|
❌ Gradle check result for a81330c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a81330c to
ed51490
Compare
|
Failed to generate code suggestions for PR |
a346d4d to
6ef0bb2
Compare
|
Persistent review updated to latest commit 6ef0bb2 |
6ef0bb2 to
00e93b5
Compare
|
Persistent review updated to latest commit 00e93b5 |
00e93b5 to
3e7a513
Compare
|
Persistent review updated to latest commit 3e7a513 |
Signed-off-by: Kavya Aggarwal <kavyaagg@amazon.com>
3e7a513 to
6272274
Compare
|
Persistent review updated to latest commit 6272274 |
|
FYI @gbbafna @GeekGlider We're no longer tracking changes in CHANGELOG, see #21071 |
Signed-off-by: Kavya Aggarwal <kavyaagg@amazon.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com>
Signed-off-by: Kavya Aggarwal <kavyaagg@amazon.com>
Description
Adds the skeleton structure for the tiering status API in server core (
org.opensearch.storage.action.tiering.status).What's locked down in this PR:
GetTieringStatusAction(indices:admin/_tier/get),ListTieringStatusAction(cluster:admin/_tier/all)GetTieringStatusRequest,GetTieringStatusResponse,ListTieringStatusRequest,ListTieringStatusResponse,TieringStatuswith serialized field declarationsRestGetTieringStatusAction(GET /{index}/_tier),RestListTieringStatusAction(GET /_tier/all)TransportGetTieringStatusAction,TransportListTieringStatusActionWhat's NOT in this PR:
Related Issues
Part of the tiered storage skeleton for WritableWarm — resolves #21078
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.